refactor: reduce code duplication in FloodFill
#1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
appgurueu
previously approved these changes
Mar 26, 2024
There was a problem hiding this comment.
You could also consider making checkLocation return a boolean - it could return whether the location is valid.
Then you'd be duplicating the two throws (but this is actually not that bad, because such side effects being "hidden" in a function may be a bit surprising).
You would then be able to deduplicate the x >= 0 && x < rgbData.length && y >= 0 && y < rgbData[0].length bounds check as well.
Co-authored-by: appgurueu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
+ Coverage 84.07% 84.08% +0.01%
==========================================
Files 375 375
Lines 19688 19685 -3
Branches 2913 2917 +4
==========================================
+ Hits 16552 16553 +1
+ Misses 3136 3132 -4 ☔ View full report in Codecov by Sentry. |
appgurueu
force-pushed
the
reduce_code_duplication_in_flood_fill
branch
from
f405dde to
1be1853
Compare
|
@appgurueu thanks for 1be1853. |
vil02
changed the title
checkLocation to FloodFillFloodFill
appgurueu
approved these changes
Mar 27, 2024
raklaptudirm
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR reduced the code duplication and adds missing tests.
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.